Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

fix: version update in a docker-compose.yaml file #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Peter-Slump
Copy link
Contributor

Description

Support updated versions in Docker Compose files.

Checklist

  • Add test cases to all the changes you introduce
  • Run ./script/format and ./script/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • [-] Update the documentation for the changes

Expected behavior

A version which is used to build a docker container should be usable to update a docker-compose.yaml file which is used to deploy that docker container. E.g. this is the case in an automated CI/CD setup using Amazon Elasticbeanstalk.

Steps to Test This Pull Request

  1. Create a docker-compose.yaml file where the version is used as tag for a docker file
  2. Add docker-compose to the version_files config setting
  3. Bump version
  4. Check if the docker-compose file is updated

Additional context

Related to issue #371

@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #375 (8638512) into master (6be8d93) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #375   +/-   ##
=======================================
  Coverage   97.59%   97.60%           
=======================================
  Files          39       39           
  Lines        1373     1378    +5     
=======================================
+ Hits         1340     1345    +5     
  Misses         33       33           
Flag Coverage Δ
unittests 97.60% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/__version__.py 100.00% <100.00%> (ø)
commitizen/bump.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a35457...8638512. Read the comment docs.

@woile woile merged commit c013297 into commitizen-tools:master Apr 22, 2021
@Peter-Slump
Copy link
Contributor Author

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants